Refactor Crc64 type #769
Merged
Refactor Crc64 type #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#5451 Split the code to static helper class, which can be used from `Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.GetPackageName`. This way the linker can strip the whole `System.Security.Cryptography.Primitives` assembly out in simple XA apps. The `Crc64` is still needed in XA, so we still keep it based on `System.Security.Cryptography.HashAlgorithm`.
radekdoulik
requested review from
grendello and
jonathanpeppers
and removed request for
jonathanpeppers
grendello
approved these changes
Jan 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5451
Split the code to static helper class, which can be used from
Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.GetPackageName.This way the linker can strip the whole
System.Security.Cryptography.Primitivesassembly out of simple XAapps.
The
Crc64is still needed in XA, so we still keep it basedon
System.Security.Cryptography.HashAlgorithm.