Skip to content

Commit 5e8a76b

Browse files
authored
[illink] Use Crc64Helper class (#5452)
Context: #5451 apk size comparison, BuildReleaseArm64False test: > apkdiff -e dll$ before.apk after.apk Size difference in bytes ([*1] apk1 only, [*2] apk2 only): - 123 assemblies/Mono.Android.dll - Type Java.Interop.Tools.JavaCallableWrappers.Crc64 Type Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager - Method static string ToHash (string, System.Security.Cryptography.HashAlgorithm) + Method static string ToCrc64 (string) + Type Java.Interop.Tools.JavaCallableWrappers.Crc64Helper - 2,975 assemblies/System.Security.Cryptography.Primitives.dll *1 Summary: - 3,098 Assemblies -0.41% (of 749,039) Update CheckIncludedAssemblies test Also bump JI to get refactoring of Crc64 type
1 parent 051cad7 commit 5e8a76b

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

external/Java.Interop

src/Mono.Android/Mono.Android.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@
9696
<Compile Include="..\..\external\Java.Interop\src\Java.Interop.Tools.JavaCallableWrappers\Java.Interop.Tools.JavaCallableWrappers\Crc64.cs">
9797
<Link>Crc64.cs</Link>
9898
</Compile>
99+
<Compile Include="..\..\external\Java.Interop\src\Java.Interop.Tools.JavaCallableWrappers\Java.Interop.Tools.JavaCallableWrappers\Crc64Helper.cs">
100+
<Link>Crc64Helper.cs</Link>
101+
</Compile>
99102
<Compile Include="..\..\external\Java.Interop\src\Java.Interop.Tools.JavaCallableWrappers\Java.Interop.Tools.JavaCallableWrappers\Crc64.Table.cs">
100103
<Link>Crc64.Table.cs</Link>
101104
</Compile>

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ public void CheckIncludedAssemblies ()
9090
"System.Linq.Expressions.dll",
9191
"System.ObjectModel.dll",
9292
"System.Runtime.Serialization.Primitives.dll",
93-
"System.Security.Cryptography.Primitives.dll",
9493
"System.Private.CoreLib.dll",
9594
"System.Collections.Concurrent.dll",
9695
"System.Collections.dll",

src/Xamarin.Android.Tools.JavadocImporter/Xamarin.Android.Tools.JavadocImporter.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
<Compile Include="..\..\external\Java.Interop\src\Java.Interop.Tools.JavaCallableWrappers\Java.Interop.Tools.JavaCallableWrappers\Crc64.cs">
2727
<Link>Crc64.cs</Link>
2828
</Compile>
29+
<Compile Include="..\..\external\Java.Interop\src\Java.Interop.Tools.JavaCallableWrappers\Java.Interop.Tools.JavaCallableWrappers\Crc64Helper.cs">
30+
<Link>Crc64Helper.cs</Link>
31+
</Compile>
2932
<Compile Include="..\..\external\Java.Interop\src\Java.Interop.Tools.JavaCallableWrappers\Java.Interop.Tools.JavaCallableWrappers\Crc64.Table.cs">
3033
<Link>Crc64.Table.cs</Link>
3134
</Compile>

0 commit comments

Comments
 (0)