Skip to content

Revert "Auto-authorize if valid refresh tokens exist" #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2020
Merged

Revert "Auto-authorize if valid refresh tokens exist" #793

merged 1 commit into from
Mar 1, 2020

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Mar 1, 2020

Reverts #754

@auvipy auvipy mentioned this pull request Mar 1, 2020
Closed
@coveralls
Copy link

coveralls commented Mar 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1284

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 94.768%
Totals Coverage Status
Change from base Build 1282: -0.008%
Covered Lines: 1268
Relevant Lines: 1338
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1284

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 94.768%
Totals Coverage Status
Change from base Build 1282: -0.008%
Covered Lines: 1268
Relevant Lines: 1338
💛 - Coveralls

@n2ygk
Copy link
Contributor

n2ygk commented Mar 1, 2020

@auvipy is this ready for review? If so, please assign to me. Thanks.

@auvipy auvipy requested a review from n2ygk March 1, 2020 14:36
@auvipy
Copy link
Contributor Author

auvipy commented Mar 1, 2020

it's just a revert

n2ygk
n2ygk approved these changes Mar 1, 2020
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@n2ygk n2ygk merged commit 6194247 into master Mar 1, 2020
@n2ygk n2ygk deleted the revert-754-autoauth-check-refresh branch March 1, 2020 15:00
@auvipy auvipy added this to the 1.3 milestone Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@auvipy @coveralls @n2ygk