Skip to content

Conversation

@madprime
Copy link
Contributor

Not ready to merge: this PR is created for feedback. Tests are failing and it's unclear to me how to correctly implement testing for this code.

This code is related to #753 to further improve the code and address concerns regarding refresh token expiration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1214

  • 14 of 15 (93.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 94.637%

Changes Missing Coverage Covered Lines Changed/Added Lines %
oauth2_provider/views/base.py 5 6 83.33%
Totals Coverage Status
Change from base Build 1186: -0.05%
Covered Lines: 1253
Relevant Lines: 1324

💛 - Coveralls

@auvipy
Copy link
Contributor

auvipy commented Mar 1, 2020

reverting #793 for now

@auvipy auvipy self-requested a review October 19, 2021 05:09
@auvipy auvipy closed this Oct 19, 2021
@auvipy auvipy reopened this Oct 19, 2021
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please fix the merge conflicts?

@n2ygk
Copy link
Contributor

n2ygk commented Jun 3, 2022

Closed as stale. Feel free to re-open if you have time to work on this.

@n2ygk n2ygk closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants