Skip to content

Conversation

@madprime
Copy link
Contributor

This implements a check on refresh tokens for auto skipping of the authorization form, as described in #753.

@coveralls
Copy link

coveralls commented Oct 23, 2019

Pull Request Test Coverage Report for Build 1185

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 94.689%

Totals Coverage Status
Change from base Build 1167: 0.008%
Covered Lines: 1248
Relevant Lines: 1318

💛 - Coveralls

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. you also need to add test for this

@madprime
Copy link
Contributor Author

@auvipy thanks, added a test which would have previously failed, and passes now. see what you think?

@auvipy auvipy merged commit a1dcd37 into django-oauth:master Oct 24, 2019
@n2ygk
Copy link
Contributor

n2ygk commented Mar 1, 2020

@madprime @auvipy I'm trying to document PRs merged between 1.2.0 and forthcoming 1.3.0 (#785) that did not make it into the CHANGELOG.md. Can you provide a one-line explanation of this feature. Is it a bug fix or added feature? Also, is this something to be documented in docs/? A documentation PR which would greatly appreciated if so.

I don't quite understand how this automatic use of Refresh Token is used. Is there a reference to the OAuth2 RFCs?

Thanks.

@auvipy
Copy link
Contributor

auvipy commented Mar 1, 2020

according to #753 (comment) and another WIP PR, I think we should revert this for now.

@auvipy
Copy link
Contributor

auvipy commented Mar 1, 2020

please check #755

n2ygk pushed a commit that referenced this pull request Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants