Skip to content

Conversation

@johannesduesing
Copy link
Contributor

Reason for this PR
This PR changes the Delphi registry HTTP interface in order to be more REST-like (as discussed here). The status report endpoints that each of the Delphi components calls have to be adapted to the new API specification.

Changes in this PR

  • Adapted URLs that are being called to the new API schema

Related PRs

  • Same changes have been done for the WebApi

Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@johannesduesing johannesduesing merged commit 83260f5 into develop Feb 4, 2019
@ghost ghost removed the review label Feb 4, 2019
@johannesduesing johannesduesing deleted the feature/newRegistryAPI branch February 4, 2019 12:02
@bhermann
Copy link
Member

bhermann commented Feb 4, 2019

There actually was an issue from codacy on this one...

@johannesduesing
Copy link
Contributor Author

I did not know that, my bad. Can you tell me what and where the issue is ? The only thing i can see here is that is says Codacy was unable to analyse your pull request.

@bhermann
Copy link
Member

bhermann commented Feb 4, 2019

No problem. The other PRs have the same issue I think. It's nothing serious though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants