Feature/new api design #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… formatting codes
This was referenced Jan 21, 2019
added 2 commits
January 21, 2019 16:53
…onflicts # Conflicts: # src/main/scala/de/upb/cs/swt/delphi/instanceregistry/RequestHandler.scala # src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala
johannesduesing
requested changes
Jan 21, 2019
Contributor
johannesduesing
left a comment
johannesduesing
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR, that was quite a lot of work and i am happy its already almost finished 👍 Please have a look at my comments below and change the code accordingly. If there are any questions regarding my comments, feel free to ask me for clarification.
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala
Show resolved
Hide resolved
src/test/scala/de/upb/cs/swt/delphi/instanceregistry/connection/ServerTest.scala
Show resolved
Hide resolved
Fixed bug when parsing JSON strings where the string would include the quotation marks
johannesduesing
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR
This PR introduces new API routes according to #57. This Pr also updates the HTTP server test cases to match the newly designed API routes as required by #81.
PS : @johannesduesing , I have commented out few test cases which I think are obsolete with respect to the new API routes. Please have a look and let me know if they have to be redesigned.