Skip to content

Conversation

@johannesduesing
Copy link

Reason for this PR
This PR changes the Delphi registry HTTP interface in order to be more REST-like (as discussed here). The status report endpoints that each of the Delphi components calls have to be adapted to the new API specification.

Changes in this PR

  • Adapted URLs that are being called to the new API schema
  • Removed unused code in InstanceRegistry.scala

bhermann
bhermann previously approved these changes Feb 4, 2019
Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov-io
Copy link

Codecov Report

Merging #42 into develop will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #42     +/-   ##
========================================
+ Coverage     1.39%   1.5%   +0.1%     
========================================
  Files           19     19             
  Lines          429    399     -30     
  Branches        33     24      -9     
========================================
  Hits             6      6             
+ Misses         423    393     -30
Impacted Files Coverage Δ
...t/delphi/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce9788...a186175. Read the comment docs.

@johannesduesing
Copy link
Author

I fixed the issue codacy was complaining about (a variable name starting with an uppercase character). This PR should be ready to merge now

@bhermann bhermann merged commit 6c50461 into develop Feb 7, 2019
@ghost ghost removed the review label Feb 7, 2019
@bhermann bhermann deleted the feature/newRegistryAPI branch February 7, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants