Reduce devtools_test.dart flakiness #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Aug 12, 2020
dwds/test/devtools_test.dart
Outdated
| alert = context.webDriver.driver.switchTo.alert; | ||
| break; | ||
| } catch (_) {} | ||
| await Future.delayed(const Duration(seconds: 2)); |
Contributor
There was a problem hiding this comment.
lets reduce this delay to like 100ms and increase the number of attempts to speed up the test
jakemac53
approved these changes
Aug 12, 2020
jakemac53
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
can not launch devtools for the same app in multiple tabstest appears to be flaky because we attempt to launch DevTools before the page is fully loaded. There isn't a good asynchronous signal for this so as an alternative we wait for the page content to sayHello World!. This closes #1084.