Skip to content

Reduce devtools_test.dart flakiness #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2020
Merged

Reduce devtools_test.dart flakiness #1086

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5178b34
Reduce devtools_test.dart flakyness
grouma Aug 11, 2020
5b76110
smaller wait
grouma Aug 12, 2020
6006765
actual fix
grouma Aug 12, 2020
aa46f15
return for break
grouma Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions dwds/test/devtools_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@ final context = TestContext(
path: 'append_body/index.html',
);

Future<void> _waitForPageReady(TestContext context) async {
var attempt = 100;
while (attempt-- > 0) {
var content = await context.webDriver.pageSource;
if (content.contains('Hello World!')) return;
await Future.delayed(const Duration(milliseconds: 100));
}
throw StateError('Page never initialized');
}

void main() {
group('Injected client', () {
setUp(() async {
Expand Down Expand Up @@ -47,6 +57,9 @@ void main() {
var devToolsWindow = windows[2];
await newAppWindow.setAsActive();

// Wait for the page to be ready before trying to open DevTools again.
await _waitForPageReady(context);

// Try to open devtools and check for the alert.
await context.webDriver.driver.keyboard.sendChord([Keyboard.alt, 'd']);
await Future.delayed(const Duration(seconds: 2));
Expand Down