got rid of duplicated error reporting code in CppCheck::checkInternal() / cleanups
#7960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Partially extracted from #7920. |
firewave
commented
Nov 14, 2025
| assert exitcode == 0, stdout | ||
| assert stdout.splitlines() == [] | ||
| assert stderr.splitlines() == [ | ||
| # TODO: should only report the error once |
Collaborator
Author
There was a problem hiding this comment.
I filed https://trac.cppcheck.net/ticket/14271 about this.
firewave
force-pushed
the
preproc-err-y
branch
2 times, most recently
from
2217242 to
fc7ba92
Compare
firewave
force-pushed
the
preproc-err-y
branch
8 times, most recently
from
bbd6576 to
612ccf1
Compare
firewave
force-pushed
the
preproc-err-y
branch
from
612ccf1 to
e287f24
Compare
|
danmar
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.