got rid of some redundant error reporting code in CppCheck::checkInternal() [skip ci]

Author: firewave

lib/cppcheck.cpp

@@ -1213,19 +1213,7 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
 
                 if (!hasValidConfig && currCfg == *configurations.rbegin()) {
                     // If there is no valid configuration then report error..
-                    std::string locfile = Path::fromNativeSeparators(o.location.file());
-                    if (mSettings.relativePaths)
-                        locfile = Path::getRelativePath(locfile, mSettings.basePaths);
-
-                    ErrorMessage::FileLocation loc1(locfile, o.location.line, o.location.col);
-
-                    ErrorMessage errmsg({std::move(loc1)},
-                                        file.spath(),
-                                        Severity::error,
-                                        o.msg,
-                                        "preprocessorErrorDirective",
-                                        Certainty::normal);
-                    mErrorLogger.reportErr(errmsg);
+                    preprocessor.error(o.location.file(), o.location.line, o.msg);
                 }
                 continue;
 

lib/preprocessor.cpp

@@ -899,7 +899,7 @@ void Preprocessor::error(const std::string &filename, unsigned int linenr, const
         if (mSettings.relativePaths)
             file = Path::getRelativePath(file, mSettings.basePaths);
 
-        locationList.emplace_back(file, linenr, 0);
+        locationList.emplace_back(file, linenr, 0); // TODO: set column
     }
     mErrorLogger.reportErr(ErrorMessage(std::move(locationList),
                                         mFile0,

lib/preprocessor.h

@@ -142,6 +142,8 @@ class CPPCHECKLIB WARN_UNUSED Preprocessor {
 
     bool reportOutput(const simplecpp::OutputList &outputList, bool showerror);
 
+    void error(const std::string &filename, unsigned int linenr, const std::string &msg);
+
 private:
     static bool hasErrors(const simplecpp::Output &output);
 
@@ -158,7 +160,6 @@ class CPPCHECKLIB WARN_UNUSED Preprocessor {
     };
 
     void missingInclude(const std::string &filename, unsigned int linenr, unsigned int col, const std::string &header, HeaderTypes headerType);
-    void error(const std::string &filename, unsigned int linenr, const std::string &msg);
 
     void addRemarkComments(const simplecpp::TokenList &tokens, std::vector<RemarkComment> &remarkComments) const;
 
@@ -172,7 +173,7 @@ class CPPCHECKLIB WARN_UNUSED Preprocessor {
     simplecpp::FileDataCache mFileCache;
 
     /** filename for cpp/c file - useful when reporting errors */
-    std::string mFile0;
+    std::string mFile0; // TODO: this is never set
     Standards::Language mLang{Standards::Language::None};
 
     /** simplecpp tracking info */

test/cli/other_test.py

@@ -3429,7 +3429,8 @@ def test_preprocess_enforced_cpp(tmp_path):  # #10989
     assert exitcode == 0, stdout if stdout else stderr
     assert stdout.splitlines() == []
     assert stderr.splitlines() == [
-        '{}:2:2: error: #error "err" [preprocessorErrorDirective]'.format(test_file)
+        # TODO: lacks column information
+        '{}:2:0: error: #error "err" [preprocessorErrorDirective]'.format(test_file)
     ]
 
 
@@ -3924,7 +3925,7 @@ def test_simplecpp_include_nested_too_deeply(tmp_path):
         # TODO: should report another ID
         # TODO: lacks column information
         '{}:1:0: error: #include nested too deeply [preprocessorErrorDirective]'.format(test_h),
-        '{}:1:2: error: #include nested too deeply [preprocessorErrorDirective]'.format(test_h)
+        '{}:1:0: error: #include nested too deeply [preprocessorErrorDirective]'.format(test_h)
     ]
 
 
@@ -3948,5 +3949,5 @@ def test_simplecpp_syntax_error(tmp_path):
         # TODO: should report another ID
         # TODO: lacks column information
         '{}:1:0: error: No header in #include [preprocessorErrorDirective]'.format(test_file),
-        '{}:1:2: error: No header in #include [preprocessorErrorDirective]'.format(test_file)
+        '{}:1:0: error: No header in #include [preprocessorErrorDirective]'.format(test_file)
     ]