fixed #14275 - map simplecpp errors to individual IDs #7966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
preproc-simple-id
branch
3 times, most recently
from
b6a17f0 to
a8b0f3a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
preproc-simple-id
branch
3 times, most recently
from
ea70b6a to
ff6c3dd
Compare
danmar
previously approved these changes
Nov 17, 2025
Owner
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
if CI is happy.. this looks good to me to merge.
firewave
force-pushed
the
preproc-simple-id
branch
2 times, most recently
from
66ebda4 to
8b8b8d6
Compare
Collaborator
Author
|
Please have another look. I had to map another error since I overlooked a location which can throw. |
firewave
force-pushed
the
preproc-simple-id
branch
from
8b8b8d6 to
cf5db64
Compare
|
danmar
approved these changes
Nov 17, 2025
firewave
commented
Nov 19, 2025
| * @param file the file | ||
| * @param cfgname cfg name | ||
| * @param createTokenList a function to create the simplecpp::TokenList with | ||
| * @param createTokenList a function to create the simplecpp::TokenList with - throws simplecpp::Output |
Collaborator
Author
There was a problem hiding this comment.
This comment might have been wrong. The errorhandling code confuses me so I flip-flop on comments in my local changes. Will amend in upcoming changes if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.