Skip to content

Conversation

mmsqe
Copy link

@mmsqe mmsqe commented Mar 7, 2025

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.19%. Comparing base (b602a26) to head (e5cd86f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/state_transition.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #574      +/-   ##
===========================================
+ Coverage    46.17%   46.19%   +0.01%     
===========================================
  Files          181      181              
  Lines        18153    18158       +5     
===========================================
+ Hits          8383     8388       +5     
  Misses        9050     9050              
  Partials       720      720              
Files with missing lines Coverage Δ
x/evm/keeper/state_transition.go 69.89% <72.72%> (+0.54%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmsqe mmsqe marked this pull request as ready for review March 10, 2025 10:00
@mmsqe mmsqe requested a review from yihuang March 10, 2025 10:00
@yihuang yihuang enabled auto-merge (squash) March 12, 2025 06:26
@yihuang yihuang merged commit 76bf49e into crypto-org-chain:develop Mar 12, 2025
37 of 39 checks passed
@yihuang yihuang deleted the debug_tx branch March 12, 2025 07:21
mmsqe added a commit that referenced this pull request Apr 8, 2025
* Problem: dependency contains personal fork (#571)

* Problem: incorrect spendable balance when debug trace tx (#574)

* Problem: incorrect spendable balance when debug trace tx

* fix

* Update tests/integration_tests/test_tracers.py

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>

* Problem: path parameter in debug_goTrace is not safe when serve public rpc (#576)

* Problem: no specific dir for the log from debug_goTrace

* lint

* allow any

* revert

* cleanup

* fix format

* fix config

* Apply suggestions from code review

---------

Co-authored-by: HuangYi <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants