Skip to content

Conversation

mmsqe
Copy link

@mmsqe mmsqe commented Apr 8, 2025

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

yihuang and others added 3 commits April 8, 2025 15:10
* Problem: incorrect spendable balance when debug trace tx

* fix

* Update tests/integration_tests/test_tracers.py

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
…c rpc (evmos#576)

* Problem: no specific dir for the log from debug_goTrace

* lint

* allow any

* revert

* cleanup

* fix format

* fix config

* Apply suggestions from code review

---------

Co-authored-by: HuangYi <[email protected]>
@mmsqe mmsqe requested a review from yihuang April 8, 2025 07:12
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
golang/github.com/crypto-org-chain/[email protected] environment, eval, filesystem, network, shell, unsafe 0 59.9 MB

🚮 Removed packages: golang/github.com/yihuang/[email protected]

View full report↗︎

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (a5405da) to head (691ec0b).
Report is 1 commits behind head on release/v1.4.x-2.

Files with missing lines Patch % Lines
rpc/namespaces/ethereum/debug/trace.go 0.00% 27 Missing ⚠️
x/evm/keeper/state_transition.go 72.72% 2 Missing and 1 partial ⚠️
server/config/config.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release/v1.4.x-2     #579      +/-   ##
====================================================
- Coverage             46.18%   46.14%   -0.05%     
====================================================
  Files                   181      181              
  Lines                 18152    18185      +33     
====================================================
+ Hits                   8384     8391       +7     
- Misses                 9048     9074      +26     
  Partials                720      720              
Files with missing lines Coverage Δ
server/flags/flags.go 50.00% <ø> (ø)
server/start.go 19.05% <100.00%> (+0.16%) ⬆️
server/config/config.go 30.09% <50.00%> (+0.19%) ⬆️
x/evm/keeper/state_transition.go 69.89% <72.72%> (+0.54%) ⬆️
rpc/namespaces/ethereum/debug/trace.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmsqe mmsqe merged commit 4ca6d42 into crypto-org-chain:release/v1.4.x-2 Apr 8, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants