Skip to content

Conversation

yihuang
Copy link

@yihuang yihuang commented Jan 17, 2025

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe January 17, 2025 09:10
@mmsqe mmsqe merged commit b602a26 into crypto-org-chain:develop Jan 17, 2025
37 of 38 checks passed
@yihuang yihuang deleted the cleanup branch January 19, 2025 14:53
mmsqe added a commit that referenced this pull request Apr 8, 2025
* Problem: dependency contains personal fork (#571)

* Problem: incorrect spendable balance when debug trace tx (#574)

* Problem: incorrect spendable balance when debug trace tx

* fix

* Update tests/integration_tests/test_tracers.py

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>

* Problem: path parameter in debug_goTrace is not safe when serve public rpc (#576)

* Problem: no specific dir for the log from debug_goTrace

* lint

* allow any

* revert

* cleanup

* fix format

* fix config

* Apply suggestions from code review

---------

Co-authored-by: HuangYi <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants