Skip to content

🔨 Switch PRModal to use useOvermind #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

🔨 Switch PRModal to use useOvermind #3431

merged 1 commit into from
Feb 13, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 31, 2020

Follow-up of #2755 & #2803

Things I did extra:

  • Fix GitProgress' result prop type
  • Use FunctionComponent instead of React.FC, since it's the same, but FunctionComponent is a bit clearer I think
  • Put all styles into the elements.ts file
  • Inline PRModal's result instead of having an extra variable
  • Export PRModal by a named export instead of a default export

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 31, 2020
@lbogdan lbogdan temporarily deployed to pr3431 January 31, 2020 12:32 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 31, 2020 •
edited
Loading

Build for latest commit ec1b3ab is at https://pr3431.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3431 January 31, 2020 13:56 Inactive
@lbogdan lbogdan temporarily deployed to pr3431 February 5, 2020 16:57 Inactive
@lbogdan lbogdan temporarily deployed to pr3431 February 5, 2020 23:53 Inactive
SaraVieira
SaraVieira approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SaraVieira SaraVieira merged commit f2c7f93 into codesandbox:master Feb 13, 2020
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Feb 13, 2020

Always a pleasure to help 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/PRModal branch February 13, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira