🔨Refactored 🧠 Overmind Hacktober | /app/pages/common/Modals/PRModal/index.js : refactor to replace Cerebral with Overmind #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/7m58avj7k |
84 tasks
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
SaraVieira
suggested changes
Oct 19, 2019
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Hey!
Seems you forgot to delete the /app/pages/common/Modals/PRModal/index.js
After that all good :D
Contributor
Author
|
@SaraVieira |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621
@Saeris @christianalfoni @SaraVieira
What is the current behavior?
/app/pages/common/Modals/PRModal/index.js was using inject and hooksObserver from app/componentConnectors and written in JS.
What is the new behavior?
uses useOvermind hook from app/overmind and converted to tsx.
What steps did you take to test this? This is required before we can merge.
Checklist