Skip to content

🔨Refactored 🧠 Overmind Hacktober | /app/pages/common/Modals/PRModal/index.js : refactor to replace Cerebral with Overmind #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2019
Merged

🔨Refactored 🧠 Overmind Hacktober | /app/pages/common/Modals/PRModal/index.js : refactor to replace Cerebral with Overmind #2755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff35356
refactor app/pages/common/Modals/PRModal/index.tsx : use overmind and…
hetpatel33 Oct 12, 2019
af411fe
removed packages/app/src/app/pages/common/Modals/PRModal/index.js
hetpatel33 Oct 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions .../app/pages/common/Modals/PRModal/index.js → ...app/pages/common/Modals/PRModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
import React from 'react';
import { inject, observer } from 'app/componentConnectors';
import { useOvermind } from 'app/overmind';
import { GitProgress } from 'app/components/GitProgress';

function PRModal({ store }) {
const PRModal: React.FC = () => {
let result = null;

if (!store.git.isCreatingPr) {
const newUrl = store.git.pr.prURL;
const {
state: {
git: {
isCreatingPr,
pr: { prURL },
},
},
} = useOvermind();

if (!isCreatingPr) {
result = (
<div>
Done! We{"'"}ll now open the new sandbox of this PR and GitHub in 3
seconds...
<div style={{ fontSize: '.875rem', marginTop: '1rem' }}>
<a href={newUrl} target="_blank" rel="noreferrer noopener">
<a href={prURL} target="_blank" rel="noreferrer noopener">
Click here if nothing happens.
</a>
</div>
Expand All @@ -27,6 +34,6 @@ function PRModal({ store }) {
message="Forking Repository & Creating PR..."
/>
);
}
};

export default inject('store')(observer(PRModal));
export default PRModal;