🔨 Refactor, 🧠 Overmind, Hacktoberfest - /app/pages/common/Modals/PRModal/index.js: convert to tsx and uses overmind #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
…to tsx and uses overmind Co-authored-by: Eliamar Tani <[email protected]>
Contributor
Author
|
@lbogdan should I solve the conflict or you'll fix it? |
SaraVieira
suggested changes
Oct 19, 2019
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Can you plese fix lint and update the imports?
Contributor
|
Build for latest commit b486fe0 is at https://pr2803.build.csb.dev/s/new. |
Contributor
Author
|
@lbogdan is everything okay with this pr? |
christianalfoni
requested changes
Oct 23, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
This looks great! You just have to fix that linting error, you can just confirm the suggested change if you want to 😄
packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Added PR for you if you are unsure how to fix the import, it also includes the linting fix: ftonato#1 You can just merge that and we should be good 👍 |
Pr christianalfoni 2803
Contributor
Author
|
Hello @christianalfoni, I have accepted your suggestion, can we merge now? |
Member
|
Ready for merge! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni
What is the current behavior?
/app/pages/common/Modals/PRModal/index.js was using inject from app/componentConnectors and written in JS.
What is the new behavior?
uses useOvermind hook from app/overmind and converted to tsx.
What steps did you take to test this? This is required before we can merge.
Checklist