Skip to content

🔨 Switch Profile/Showcase to use useOvermind #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

🔨 Switch Profile/Showcase to use useOvermind #3409

merged 1 commit into from
Feb 13, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 29, 2020

Follow-up of #2766 & #2967

Things I did extra:

  • Put all styles into the elements.ts file
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Extract LoadingSandbox & NoSandboxAvailable out of Showcase

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 29, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from 1cec584 to 5c1d570 Compare January 29, 2020 13:48
@lbogdan lbogdan temporarily deployed to pr3409 January 29, 2020 13:55 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 29, 2020 •
edited
Loading

Build for latest commit 64151ab is at https://pr3409.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from 5c1d570 to ceaf0d2 Compare January 30, 2020 23:45
@lbogdan lbogdan temporarily deployed to pr3409 January 30, 2020 23:51 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from ceaf0d2 to 8fd1789 Compare January 31, 2020 13:38
@lbogdan lbogdan temporarily deployed to pr3409 January 31, 2020 13:49 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from 8fd1789 to a5a4cb0 Compare February 5, 2020 16:38
@lbogdan lbogdan temporarily deployed to pr3409 February 5, 2020 16:49 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from a5a4cb0 to 591aed5 Compare February 5, 2020 23:38
@lbogdan lbogdan temporarily deployed to pr3409 February 5, 2020 23:46 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from 591aed5 to 47bb96f Compare February 8, 2020 12:35
@lbogdan lbogdan temporarily deployed to pr3409 February 8, 2020 12:47 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Showcase branch from 47bb96f to 64151ab Compare February 13, 2020 21:40
SaraVieira
SaraVieira approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SaraVieira SaraVieira merged commit 601d1f4 into codesandbox:master Feb 13, 2020
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Feb 14, 2020

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/Profile-Showcase branch February 14, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira