Refactor /app/pages/Profile/Showcase/index.js to /app/pages/Profile/Showcase/index.tsx 🔨 Refactor 🧠 Overmind Hacktoberfest #2766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/Showcase/index.tsx`
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/e3y49y6tu |
ganes1410
changed the title
/app/pages/Profile/Showcase/index.js to `/app/pages/Profil…/app/pages/Profile/Showcase/index.js to /app/pages/Profile/Showcase/index.tsx 🔨 Refactor 🧠 Overmind Hacktoberfest
Contributor
Author
|
Hi @Saeris , The typecheck failed locally at first. Then I changed the file in |
ganes1410
changed the title
/app/pages/Profile/Showcase/index.js to /app/pages/Profile/Showcase/index.tsx 🔨 Refactor 🧠 Overmind Hacktoberfest
ganes1410
changed the title
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
84 tasks
Member
|
Almost ready to merge!! Could you merge with master and try to fix the typecheck? Then it's ready for go! |
Contributor
Author
|
Hi, @CompuIves. Are you talking to someone else? I don't think I can merge to master. |
This was referenced Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor #2621 @Saeris @christianalfoni
What is the current behavior?
It was using class component with js file, and cerebral for state management
What is the new behavior?
It now uses tsx instead of js. And Overmind is used for state management with help of
useOvermindhookWhat steps did you take to test this? This is required before we can merge.
yarn lintyarn testyarn typecheckChecklist