Skip to content

Fix SandboxInfo #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2019
Merged

Fix SandboxInfo #2967

merged 1 commit into from
Nov 15, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Nov 3, 2019

Follow-up of #2961

@lbogdan lbogdan temporarily deployed to pr2967 November 3, 2019 17:00 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 3, 2019 •
edited
Loading

Build for latest commit 615fe9d is at https://pr2967.build.csb.dev/s/new.

CompuIves
CompuIves requested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the conversion to ts! I left a comment about the use of store, I think we could do without it in this case.

@lbogdan lbogdan temporarily deployed to pr2967 November 7, 2019 22:30 Inactive
@lbogdan lbogdan temporarily deployed to pr2967 November 13, 2019 17:10 Inactive
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Nov 13, 2019

Ping @CompuIves

CompuIves
CompuIves approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@CompuIves CompuIves merged commit 2256508 into codesandbox:master Nov 15, 2019
@MichaelDeBoey MichaelDeBoey deleted the fix-SandboxInfo branch November 15, 2019 12:38
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CompuIves CompuIves CompuIves approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @CompuIves