fix: show like button on showcase title when the user is logged in #2961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit 16233aa is at https://pr2961.build.csb.dev/s/new. |
Member
|
This is really great (and that's some ancient code), thanks for this fix! |
CompuIves
approved these changes
Nov 3, 2019
Contributor
Author
|
Hey right, the UI also seems different for showcase modal with white background. Maybe enhancing it can be the next steps. On other note, do lmk if there is something I can help you with. Always a pleasure working on CodeSandbox :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improvement. Not sure if this was intentional as the like button doesn't work but I guess its better to not show like in Editor at the top.
What is the current behavior?
Like button visible in showcase even when the user is logged out.
What is the new behavior?
Show like button only when logged in, like in editor.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist