change: upper bounding dependency on sagemaker-training-toolkit #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
bhaoz
reviewed
Jun 3, 2025
| ignore = | ||
| C901, | ||
| E203, # whitespace before ':': Black disagrees with and explicitly violates this. | ||
| E203, |
Contributor
Author
There was a problem hiding this comment.
adding inline comments were not compatible and tests were failing
bhaoz
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upper-bounding dependency on sagemaker-training-toolkit to 4.8.3. This is done to prevent backwards compatibility, as there is ongoing effort to update the protobuf version in sage-maker-toolkit in a new major release, which would may cause issues for packages that are its dependencies: aws/sagemaker-training-toolkit#235
All unit tests passing:
Fixing ongoing build and test issues:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.