-
Notifications
You must be signed in to change notification settings - Fork 137
breaking: updating protobuf version to 5.28.1 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
| ### Breaking Changes | ||
| **Upgraded `protobuf` to v5.28.1** | ||
|
|
||
| * This upgrade introduces a breaking change due to `protobuf` v5.28.1 dropping support for Python versions earlier than 3.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to confirm - 3.8 is still supported right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 3.8 is supported
| @@ -1,796 +1,64 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a guide on how to generated this pb cimplier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was generated using bin/protoc —python_out=. record.proto
For some reason, record.proto is not in this package, but exists in other packages such as sagemaker-python-sdk
That record.proto was used to generate this file
5df432c to
3220a92
Compare
bhaoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed integ tests all passing for this repo
Description of changes:
Updated protobuf version to 5.28.1
Updated record_pb2.py to support protobuf changes
Upgraded tensorflow dependency in integration test docker file, as previous version did not support protobuf version to 5.28.1
Upgraded integration test docker python version to support protobuf version to 5.28.1 and updated record_pb2.py
Marking this change as a major version release - 5.0.0 (Need to be tagged when merged)
Testing done:
All unit tests are passing:
All integration tests are passing
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.