Skip to content

Conversation

@nandiso123
Copy link
Contributor

@nandiso123 nandiso123 commented May 28, 2025

Description of changes:
Updated protobuf version to 5.28.1
Updated record_pb2.py to support protobuf changes
Upgraded tensorflow dependency in integration test docker file, as previous version did not support protobuf version to 5.28.1
Upgraded integration test docker python version to support protobuf version to 5.28.1 and updated record_pb2.py

Marking this change as a major version release - 5.0.0 (Need to be tagged when merged)

Testing done:
All unit tests are passing:

Wrote HTML report to htmlcov/index.html
  black-format: OK (3.20=setup[3.06]+cmd[0.14] seconds)
  flake8: OK (2.66=setup[2.15]+cmd[0.51] seconds)
  pylint: OK (3.09=setup[0.01]+cmd[3.08] seconds)
  twine: OK (2.76=setup[2.23]+cmd[0.27,0.26] seconds)
  py38: OK (234.17=setup[1.32]+cmd[231.78,0.31,0.76] seconds)
  py39: OK (233.08=setup[2.38]+cmd[229.65,0.31,0.74] seconds)
  py310: OK (231.21=setup[2.38]+cmd[227.81,0.29,0.72] seconds)
  congratulations :) (710.22 seconds)

All integration tests are passing

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ X] I have read the CONTRIBUTING doc
  • [ X] I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • [X ] I have updated any necessary documentation, including READMEs

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nandiso123 nandiso123 requested a review from a team as a code owner May 28, 2025 21:52
@benieric

This comment has been minimized.

### Breaking Changes
**Upgraded `protobuf` to v5.28.1**

* This upgrade introduces a breaking change due to `protobuf` v5.28.1 dropping support for Python versions earlier than 3.8.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to confirm - 3.8 is still supported right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 3.8 is supported

@@ -1,796 +1,64 @@
# -*- coding: utf-8 -*-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a guide on how to generated this pb cimplier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was generated using bin/protoc —python_out=. record.proto

For some reason, record.proto is not in this package, but exists in other packages such as sagemaker-python-sdk

That record.proto was used to generate this file

Copy link
Collaborator

@bhaoz bhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed integ tests all passing for this repo

@bhaoz bhaoz merged commit 04211b8 into aws:master Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants