Skip to content

change: upper bounding dependency on sagemaker-training-toolkit #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

change: upper bounding dependency on sagemaker-training-toolkit #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec71d68
change: upper bounding dependency on sagemaker-training-toolkit
nandiso123 May 30, 2025
5989777
fix flake8 failure
nandiso123 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def read(fname):
'Programming Language :: Python :: 3.9',
],

install_requires=['retrying', 'sagemaker-training>=4.3.0', 'six>=1.12.0'],
install_requires=['retrying', 'sagemaker-training>=4.3.0,<=4.8.3', 'six>=1.12.0'],
extras_require={
'test': test_dependencies
},
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ exclude =
max-complexity = 10
ignore =
C901,
E203, # whitespace before ':': Black disagrees with and explicitly violates this.
E203,
Copy link

@bhaoz bhaoz Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing those comments?

Copy link
Contributor Author

@nandiso123 nandiso123 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding inline comments were not compatible and tests were failing

FI10,
FI12,
FI13,
FI14,
FI15,
FI16,
FI17,
FI18, # __future__ import "annotations" missing -> check only Python 3.7 compatible
FI18,
FI50,
FI51,
FI52,
Expand Down