[SPARK-41752][SQL][FOLLOW-UP] Fix Protobuf serializer for SQLExecutionUIData #39489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Jan 10, 2023
| bool metric_values_is_null = 12; | ||
| map<int64, string> metric_values = 13; | ||
| optional int64 root_execution_id = 14; | ||
| int64 root_execution_id = 2; |
Member
Author
There was a problem hiding this comment.
since we haven't released the protobuf file, I move root_execution_id to the 2nd field and make it required instead of optional. This matches the definition of SQLExecutionUIData.
Member
Author
|
cc @linhongliu-db @cloud-fan @dongjoon-hyun I found this during post-review. |
Member
Author
|
@dongjoon-hyun Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The new field
rootExecutionIdofSQLExecutionUIDatais not correctly serialized/deserialized in #39268. This PR is to fix it.Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT