Skip to content

[SPARK-41752][SQL][FOLLOW-UP] Fix Protobuf serializer for SQLExecutionUIData #39489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-41752][SQL][FOLLOW-UP] Fix Protobuf serializer for SQLExecutionUIData #39489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,19 +405,19 @@ message SQLPlanMetric {

message SQLExecutionUIData {
int64 execution_id = 1;
string description = 2;
string details = 3;
string physical_plan_description = 4;
map<string, string> modified_configs = 5;
repeated SQLPlanMetric metrics = 6;
int64 submission_time = 7;
optional int64 completion_time = 8;
optional string error_message = 9;
map<int64, JobExecutionStatus> jobs = 10;
repeated int64 stages = 11;
bool metric_values_is_null = 12;
map<int64, string> metric_values = 13;
optional int64 root_execution_id = 14;
int64 root_execution_id = 2;
Copy link
Member Author

@gengliangwang gengliangwang Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we haven't released the protobuf file, I move root_execution_id to the 2nd field and make it required instead of optional. This matches the definition of SQLExecutionUIData.

string description = 3;
string details = 4;
string physical_plan_description = 5;
map<string, string> modified_configs = 6;
repeated SQLPlanMetric metrics = 7;
int64 submission_time = 8;
optional int64 completion_time = 9;
optional string error_message = 10;
map<int64, JobExecutionStatus> jobs = 11;
repeated int64 stages = 12;
bool metric_values_is_null = 13;
map<int64, string> metric_values = 14;
}

message SparkPlanGraphNode {
Expand Down
1 change: 1 addition & 0 deletions ...re/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class SQLExecutionUIDataSerializer extends ProtobufSerDe {
val ui = input.asInstanceOf[SQLExecutionUIData]
val builder = StoreTypes.SQLExecutionUIData.newBuilder()
builder.setExecutionId(ui.executionId)
builder.setRootExecutionId(ui.rootExecutionId)
builder.setDescription(ui.description)
builder.setDetails(ui.details)
builder.setPhysicalPlanDescription(ui.physicalPlanDescription)
Expand Down
1 change: 1 addition & 0 deletions .../src/test/scala/org/apache/spark/status/protobuf/sql/KVStoreProtobufSerializerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class KVStoreProtobufSerializerSuite extends SparkFunSuite {
val bytes = serializer.serialize(input)
val result = serializer.deserialize(bytes, classOf[SQLExecutionUIData])
assert(result.executionId == input.executionId)
assert(result.rootExecutionId == input.rootExecutionId)
assert(result.description == input.description)
assert(result.details == input.details)
assert(result.physicalPlanDescription == input.physicalPlanDescription)
Expand Down