[SPARK-28599][SQL] Fix Execution Time and Duration column sorting for ThriftServerSessionPage

[wangyum]

What changes were proposed in this pull request?

This PR add support sorting Execution Time and Duration columns for ThriftServerSessionPage.

Why are the changes needed?

Previously, it's not sorted correctly.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Manually do the following and test sorting on those columns in the Spark Thrift Server Session Page.

$ sbin/start-thriftserver.sh
$ bin/beeline -u jdbc:hive2://localhost:10000
0: jdbc:hive2://localhost:10000> create table t(a int);
+---------+--+
| Result  |
+---------+--+
+---------+--+
No rows selected (0.521 seconds)
0: jdbc:hive2://localhost:10000> select * from t;
+----+--+
| a  |
+----+--+
+----+--+
No rows selected (0.772 seconds)
0: jdbc:hive2://localhost:10000> show databases;
+---------------+--+
| databaseName  |
+---------------+--+
| default       |
+---------------+--+
1 row selected (0.249 seconds)

Sorted by Execution Time column:

Sorted by Duration column:

[wangyum]

cc @amanomer

[amanomer]

Looks good. Nice catch @wangyum .

[SparkQA]

Test build #111154 has finished for PR 25892 at commit e794fe2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[amanomer]

I would like to take this in branch-2.4 by #25882.

[dongjoon-hyun]

@amanomer and @wangyum .
It seems that idea is already reverted from #25882.

In general, please do not mix different ones. Especially, it's not a good idea when the original one is not merged yet. :)

[dongjoon-hyun]

BTW, @wangyum .
As a committer, please make it sure if the PR keeps the original four sections template of the PR.
For me, it seems that it's removed accidentally in this PR. It will be better if you recover it. 😄
cc @HyukjinKwon .

[amanomer]

Ok. I have created another PR #25893 to back-port this to branch-2.4.

[dongjoon-hyun]

Hi, @wangyum .
Did you check the original STS behavior?

[dongjoon-hyun]

In addition, this PR description is wrong. This is UI PR and that's the reason why you attach the screenshot. Could you fix the PR description?

Does this PR introduce any user-facing change?

No.

[dongjoon-hyun]

Note that I fixed the PR description issues by

1. Recovering the missing section
2. Fixing UI section from NO to YES.
3. Updating the test procedure for reviewers. (The section is for the reviewers mainly.)

+1, LGTM. Thank you, @wangyum and @amanomer .

[dongjoon-hyun]

Merged to master.

[dongjoon-hyun]

I changed SPARK-28599 from Improvement to Bug.
Since this is a bug fix, we can backport this merged commit (with the fixed commit messages). However, in branch-2.4, there is no Execution Time column. There is Duration column only.
Please make it sure during backporting.