[SPARK-28599][SQL][2.4] Fix Duration column sorting for ThriftServerSessionPage
#25906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for ThriftServerSessionPage This PR add support sorting `Execution Time` and `Duration` columns for `ThriftServerSessionPage`. Previously, it's not sorted correctly. Yes. Manually do the following and test sorting on those columns in the Spark Thrift Server Session Page. ``` $ sbin/start-thriftserver.sh $ bin/beeline -u jdbc:hive2://localhost:10000 0: jdbc:hive2://localhost:10000> create table t(a int); +---------+--+ | Result | +---------+--+ +---------+--+ No rows selected (0.521 seconds) 0: jdbc:hive2://localhost:10000> select * from t; +----+--+ | a | +----+--+ +----+--+ No rows selected (0.772 seconds) 0: jdbc:hive2://localhost:10000> show databases; +---------------+--+ | databaseName | +---------------+--+ | default | +---------------+--+ 1 row selected (0.249 seconds) ``` **Sorted by `Execution Time` column**:  **Sorted by `Duration` column**:  Closes apache#25892 from wangyum/SPARK-28599. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
srowen
approved these changes
Sep 23, 2019
|
Test build #4882 has finished for PR 25906 at commit
|
dongjoon-hyun
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Thank you, @amanomer . This backporting is correctly made by using @wangyum 's authorship.
I fixed the followings because this PR still ignored my advice on the original PR.
- I fixed the title because this PR doesn't fix
Execution Timecolumn because it doesn't exist. - I fixed the PR description with the same reason, also removed the first image
Sorted by Execution Time column:
The renaming image is technically wrong because it's a screenshot of 3.0.0-SNAPSHOT. We had better replace it with 2.4.5-SNAPSHOT. However, it's understandable.
dongjoon-hyun
changed the title
Execution Time and Duration column sorting for ThriftServerSessionPageDuration column sorting for ThriftServerSessionPage
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 23, 2019
…rSessionPage ### What changes were proposed in this pull request? This PR add support sorting `Duration` columns for `ThriftServerSessionPage`. ### Why are the changes needed? Previously, it's not sorted correctly. ### Does this PR introduce any user-facing change? Yes. ### How was this patch tested? Manually do the following and test sorting on those columns in the Spark Thrift Server Session Page. ``` $ sbin/start-thriftserver.sh $ bin/beeline -u jdbc:hive2://localhost:10000 0: jdbc:hive2://localhost:10000> create table t(a int); +---------+--+ | Result | +---------+--+ +---------+--+ No rows selected (0.521 seconds) 0: jdbc:hive2://localhost:10000> select * from t; +----+--+ | a | +----+--+ +----+--+ No rows selected (0.772 seconds) 0: jdbc:hive2://localhost:10000> show databases; +---------------+--+ | databaseName | +---------------+--+ | default | +---------------+--+ 1 row selected (0.249 seconds) ``` **Sorted by `Duration` column**:  Closes #25906 from amanomer/BP_28599. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Thank you all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR add support sorting
Durationcolumns forThriftServerSessionPage.Why are the changes needed?
Previously, it's not sorted correctly.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Manually do the following and test sorting on those columns in the Spark Thrift Server Session Page.
Sorted by
Durationcolumn: