[SPARK-28599][WEBUI][2.4] Support sorting Execution Time and Duration columns for ThriftServerSessionPage
#25893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion` columns for ThriftServerSessionPage
|
Can one of the admins verify this patch? |
|
Please do not make a PR for the unmarked PR. |
|
Got a lesson. Thank you @dongjoon-hyun. One query, can we re-open this PR after PR #25892 get merged? |
|
This sounds fair. I will keep this in mind. |
|
Still want to back-port 51d3509 to branch-2.4 and soon raise a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR add support for sorting
Durationcolumn forThriftServerSessionPage.Why are the changes needed?
Sorting on duration columns consider time as a string after converting into readable form which is the reason for wrong sort results as mentioned in SPARK_28599.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested manually.
Back-port of #25892