[SPARK-18816] [Web UI] Executors Logs column only ran visibility check on initial table load #16256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on each page load
Member
Author
|
@srowen and @tgravescs could you take a quick look at this fix for a bug @yhuai found |
Member
Author
|
Also in case the others are on vacation, @vanzin want to take a look too? |
|
Test build #70039 has finished for PR 16256 at commit
|
srowen
reviewed
Dec 13, 2016
| }; | ||
|
|
||
| $(selector).DataTable(conf); | ||
| var dt = $(selector).DataTable(conf); |
Member
There was a problem hiding this comment.
You know better than I how to implement this. Does the same logic apply to column 16's init above?
Member
Author
There was a problem hiding this comment.
No, the column 16 logic is based on a conf flag, 15 is based on a function using the current page data
Member
|
Merged to master (and 2.1 because original change is in 2.1) |
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2016
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in #14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes #16256 from ajbozarth/spark18816. (cherry picked from commit aebf44e) Signed-off-by: Sean Owen <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in apache#14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes apache#16256 from ajbozarth/spark18816.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in apache#14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes apache#16256 from ajbozarth/spark18816.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When I added a visibility check for the logs column on the executors page in #14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same.
How was this patch tested?
Tested Manually
No visible UI changes to screenshot.