Skip to content

[SPARK-18816] [Web UI] Executors Logs column only ran visibility check on initial table load #16256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-18816] [Web UI] Executors Logs column only ran visibility check on initial table load #16256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions core/src/main/resources/org/apache/spark/ui/static/executorspage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,6 @@ $(document).ready(function () {
}
],
"columnDefs": [
{
"targets": [ 15 ],
"visible": logsExist(response)
},
{
"targets": [ 16 ],
"visible": getThreadDumpEnabled()
Expand All @@ -423,7 +419,8 @@ $(document).ready(function () {
"order": [[0, "asc"]]
};

$(selector).DataTable(conf);
var dt = $(selector).DataTable(conf);
Copy link
Member

@srowen srowen Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know better than I how to implement this. Does the same logic apply to column 16's init above?

Copy link
Member Author

@ajbozarth ajbozarth Dec 13, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the column 16 logic is based on a conf flag, 15 is based on a function using the current page data

dt.column(15).visible(logsExist(response));
$('#active-executors [data-toggle="tooltip"]').tooltip();

var sumSelector = "#summary-execs-table";
Expand Down