[SPARK-16673] [Web UI] New Executor Page removed conditional for Logs and Thread Dump columns #14382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
#14204 will also need this conditional logic, so once this or that is merged the other will need to update to add that logic. (I've already written it) |
Member
Author
|
Looping in those who reviewed the previous pr: @nblintao @kishorvpatil @tgravescs @zhuoliu |
Member
Author
|
I also included a bit of clean up from #13670 in regards to |
|
Test build #62932 has finished for PR 14382 at commit
|
Contributor
|
It looks great from the code. I will try it tomorrow or later. Thanks for fixing this! |
Member
Author
|
@tgravescs @srowen would you be willing to take a quick look at this? |
Member
|
I see, I tend to trust your work here. The result looks OK. Looks like this only needs to go to master |
Contributor
|
changes look fine. +1, thanks for fixing this. |
nblintao
added a commit
to nblintao/spark
that referenced
this pull request
Aug 28, 2016
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2016
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in #14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes #16256 from ajbozarth/spark18816. (cherry picked from commit aebf44e) Signed-off-by: Sean Owen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2016
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in #14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes #16256 from ajbozarth/spark18816.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in apache#14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes apache#16256 from ajbozarth/spark18816.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… on initial table load ## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in apache#14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes apache#16256 from ajbozarth/spark18816.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When #13670 switched
ExecutorsPageto use JQuery DataTables it incidentally removed the conditional for the Logs and Thread Dump columns. I reimplemented the conditional display of the Logs and Thread dump columns as it was before the switch.How was this patch tested?
Manually tested and dev/run-tests