[SPARK-17513][SQL] Make StreamExecution garbage-collect its metadata #15166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is based on work by frreiss in apache#15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Author: frreiss <[email protected]> Closes apache#15126 from petermaxlee/SPARK-17513.
petermaxlee
changed the title
|
Test build #65674 has finished for PR 15166 at commit
|
| AssertOnQuery("metadata log should contain only one file") { q => | ||
| val metadataLogDir = new java.io.File(q.offsetLog.metadataPath.toString) | ||
| val logFileNames = metadataLogDir.listFiles().toSeq.map(_.getName()) | ||
| val toTest = logFileNames.filter(! _.endsWith(".crc")) // Workaround for SPARK-17475 |
Contributor
There was a problem hiding this comment.
Is the space between ! and _ intentionally added? I saw other similar code not having a space.
Contributor
Author
There was a problem hiding this comment.
I think @frreiss added this to be more obvious. I don't really have a preference here.
Contributor
There was a problem hiding this comment.
Either way is fine with me.
frreiss
reviewed
Sep 20, 2016
| val logFileNames = metadataLogDir.listFiles().toSeq.map(_.getName()) | ||
| val toTest = logFileNames.filter(! _.endsWith(".crc")) // Workaround for SPARK-17475 | ||
| assert(toTest.size == 1 && toTest.head == "2") | ||
| true |
Contributor
There was a problem hiding this comment.
This line ("true") shouldn't be here. It makes the Assert always pass, even when the condition on the previous line isn't satisfied.
Contributor
Author
There was a problem hiding this comment.
It still fails. There was an assert there.
Contributor
There was a problem hiding this comment.
Ah, yes. The previous like (146) should be just toTest.size == 1 && toTest.head == "2", with no "assert".
Contributor
|
merging in master/2.0. Thanks. |
asfgit
pushed a commit
that referenced
this pull request
Sep 21, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is a resubmission of 15126, which was based on work by frreiss in #15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Closes #15166 from petermaxlee/SPARK-17513-2. (cherry picked from commit 976f3b1) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235.
This is a resubmission of 15126, which was based on work by frreiss in #15067, but fixed the test case along with some typos.
How was this patch tested?
A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request.