[SPARK-17513][SQL] Make StreamExecution garbage-collect its metadata #15126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SPARK-17513] [STREAMING] [SQL] Make StreamExecution garbage-collect its metadata
Member
|
@petermaxlee why are we not making this change in #15067 ? looks like you forked someone else's PR while it was active. |
|
Test build #65528 has finished for PR 15126 at commit
|
|
Test build #3277 has finished for PR 15126 at commit
|
|
Test build #65527 has finished for PR 15126 at commit
|
Contributor
|
Since @frreiss hasn't updated the pr yet, I'm going to merge this one and assign the jira ticket to Fred. |
Contributor
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is based on work by frreiss in #15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Author: frreiss <[email protected]> Closes #15126 from petermaxlee/SPARK-17513. (cherry picked from commit be9d57f) Signed-off-by: Reynold Xin <[email protected]>
Contributor
|
This PR breaks the master branch, I have reverted it, @petermaxlee can you resend and fix the test? thanks! |
petermaxlee
added a commit
to petermaxlee/spark
that referenced
this pull request
Sep 20, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is based on work by frreiss in apache#15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Author: frreiss <[email protected]> Closes apache#15126 from petermaxlee/SPARK-17513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235.
This is based on work by @frreiss in #15067, but fixed the test case along with some typos.
How was this patch tested?
A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request.