[SPARK-17513] [STREAMING] [SQL] Make StreamExecution garbage-collect its metadata #15067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Jenkins, test this please. |
Contributor
|
Looks pretty good to me. |
petermaxlee
added a commit
to petermaxlee/spark
that referenced
this pull request
Sep 17, 2016
[SPARK-17513] [STREAMING] [SQL] Make StreamExecution garbage-collect its metadata
petermaxlee
suggested changes
Sep 17, 2016
| val metadataLogDir = new java.io.File(q.offsetLog.metadataPath.toString) | ||
| val logFileNames = metadataLogDir.listFiles().toSeq.map(_.getName()) | ||
| val toTest = logFileNames.filter(! _.endsWith(".crc")) // Workaround for SPARK-17475 | ||
| toTest.size == 1 && toTest.head == "2" |
Contributor
There was a problem hiding this comment.
actually this test case will always pass, even without the change here. I will submit a patch based on yours that fixes the issues here.
Contributor
Author
There was a problem hiding this comment.
Oops, didn't notice I had left that "true" at the end of that block of code. @petermaxlee , let me know if you need help preparing the final version for merge.
|
Test build #65525 has finished for PR 15067 at commit
|
|
Test build #3276 has finished for PR 15067 at commit
|
Contributor
|
@frreiss can you close this now? |
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is based on work by frreiss in #15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Author: frreiss <[email protected]> Closes #15126 from petermaxlee/SPARK-17513.
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is based on work by frreiss in #15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Author: frreiss <[email protected]> Closes #15126 from petermaxlee/SPARK-17513. (cherry picked from commit be9d57f) Signed-off-by: Reynold Xin <[email protected]>
petermaxlee
added a commit
to petermaxlee/spark
that referenced
this pull request
Sep 20, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is based on work by frreiss in apache#15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Author: frreiss <[email protected]> Closes apache#15126 from petermaxlee/SPARK-17513.
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Sep 21, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is a resubmission of 15126, which was based on work by frreiss in apache#15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Closes apache#15166 from petermaxlee/SPARK-17513-2.
asfgit
pushed a commit
that referenced
this pull request
Sep 21, 2016
## What changes were proposed in this pull request? This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the purge method that was added as part of SPARK-17235. This is a resubmission of 15126, which was based on work by frreiss in #15067, but fixed the test case along with some typos. ## How was this patch tested? A new test case in StreamingQuerySuite. The test case would fail without the changes in this pull request. Author: petermaxlee <[email protected]> Closes #15166 from petermaxlee/SPARK-17513-2. (cherry picked from commit 976f3b1) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies StreamExecution such that it discards metadata for batches that have already been fully processed. I used the
purgemethod that was added as part of SPARK-17235.How was this patch tested?
I added a test case to verify that old metadata log files are correctly purged.
I also ran the entire regression suite.