feat(build): Add Checkstyle plugin and an IllegalImport rule #1880

adutra · 2025-06-12T15:15:18Z

Now ready for review.

I'm implementing my own suggestion of using a Checkstyle rule to check for forbidden packages.

adutra · 2025-06-12T15:16:41Z

quarkus/test-commons/build.gradle.kts

Checkstyle depends on antlr4-runtime.

snazy · 2025-06-13T12:01:38Z

build-logic/src/main/kotlin/polaris-java.gradle.kts


+// Ensure Checkstyle runs after jandex to avoid task dependency issues
+tasks
+  .matching { it.name.startsWith("checkstyle") }


This is a trap and prevents "configure on demand", .matching gives you the fully configured tasks.
I'd use

tasks.withType<Checkstyle>().configureEach { ...

snazy · 2025-06-13T12:02:33Z

build-logic/src/main/kotlin/polaris-java.gradle.kts

-if (project.extra.has("duplicated-project-sources")) {
-  // skip the style check for duplicated projects
-  tasks.withType<Checkstyle>().configureEach { enabled = false }
+val checkstyleVersion =


Nit: move this into the checkstyle { block.

dimas-b · 2025-06-13T14:53:09Z

codestyle/checkstyle.xml

+    <!-- See http://checkstyle.org/config_imports.html -->
+    <module name="IllegalImport">
+      <property name="illegalPkgs"
+        value="org.apache.iceberg.shaded, org.apache.iceberg.relocated, org.testcontainers.shaded"/>


nit: I wonder if we could have **.shaded.**, **.relocated.**?

it looks like regexp is allowed 🤔

snazy · 2025-06-13T16:25:07Z

Not against this PR, but wouldn't it be better to not even have those dependencies that bring relocated code or not have dependencies on uber jars at all, as long as there are alternatives?

adutra · 2025-06-13T16:40:50Z

Not against this PR, but wouldn't it be better to not even have those dependencies that bring relocated code or not have dependencies on uber jars at all, as long as there are alternatives?

Well, we certainly could try to ban the iceberg shaded dependencies, but afair the Spark Client module is fairly complex in terms of dependency management.

And as for Testcontainers, I think that if your tests require testcontainers, you get the testcontainers shaded dependencies (e.g. Awaitility) "for free" 🤷‍♂️ – and there is no way to exclude them since they are in the same jar.

gh-yzou · 2025-06-13T21:18:32Z

plugins/spark/v3.5/spark/build.gradle.kts

 }

-// TODO: replace the check using gradlew checkstyle plugin
-tasks.register("checkNoDisallowedImports") {


Thanks for help getting rid of that

* Cleanup unnecessary files in client/python (apache#1878) Cleanup unnecessary files in `client/python` * Bump version in version.txt With the release/1.0.0 branch being cut, we should bump this to reflect the current state of main * JDBC: Refactor DatabaseOps (apache#1843) * removes the databaseType computation from JDBCMetastoreManagerFactory to DbOperations * wraps the bootstrap in a transaction ! * refactor Production Readiness checks for Postgres * Fix two wrong links in README.md (apache#1879) * Avoid using org.testcontainers.shaded.** (apache#1876) * main: Update dependency io.smallrye.config:smallrye-config-core to v3.13.2 (apache#1888) * main: Update registry.access.redhat.com/ubi9/openjdk-21-runtime Docker tag to v1.22-1.1749462970 (apache#1887) * main: Update dependency boto3 to v1.38.36 (apache#1886) * fix(build): Fix deprecation warnings in PolarisIntegrationTestExtension (apache#1895) * Enable patch version updates for maintained Polaris version (apache#1891) Polaris 1.x will be a supported/maintained release. It is crucial to apply bug and security fixes to such release branches. Therefore, this change enables patch-version updates for Polaris 1.* * Add Polaris community meeting record for 2025-06-12 (apache#1892) * Do not use relative path inside CLI script Issue apache#1868 reported that the Polaris script can fail when it's run from an unexpected path. The recent addition of a reference to `./gradlew` looks incorrect here, and should be changed to use an absolute path. Fixes apache#1868 * feat(build): Add Checkstyle plugin and an IllegalImport rule (apache#1880) * Python CI: pin mypy version to avoid CI failure due to new release (apache#1903) Mypy did a new release 1.16.1 and it cause our CI to fail for about 20 minutes due to missing wheel (upload not completed) ``` | Unable to find installation candidates for mypy (1.16.1) | | This is likely not a Poetry issue. | | - 14 candidate(s) were identified for the package | - 14 wheel(s) were skipped as your project's environment does not support the identified abi tags | | Solutions: | Make sure the lockfile is up-to-date. You can try one of the following; | | 1. Regenerate lockfile: poetry lock --no-cache --regenerate | 2. Update package : poetry update --no-cache mypy | | If neither works, please first check to verify that the mypy has published wheels available from your configured source that are compatible with your environment- ie. operating system, architecture (x86_64, arm64 etc.), python interpreter. | ``` This PR temporarily restrict the mypy version to avoid the similar issue. We may consider bring poetry.lock back to git tracking so we won't automatically update test dependencies all the time * Remove `.github/CODEOWNERS` (apache#1902) As per this [dev-ML discussion](https://lists.apache.org/thread/jjr5w3hslk755yvxy8b3z45c7094cxdn) * Rename quarkus as runtime (apache#1695) * Rename runtime/test-commons to runtime/test-common (for consistency with module name) (apache#1906) * docs: Add `Polaris Evolution` page (apache#1890) --------- Co-authored-by: Eric Maynard <[email protected]> * feat(ci): Split Java Gradle CI in many jobs to reduce execution time (apache#1897) * Add webpage for Generic Table support (apache#1889) * add change * add comment * address feedback * update limitations * update docs * update doc * address feedback * Improve the parsing and validation of UserSecretReferenceUrns (apache#1840) This change addresses all the TODOs found the org.polaris.core.secrets package. Main changes: - Create a helper to parse, validate and build the URN strings. - Use Regex instead of `String.split()`. - Add Precondition checks to ensure that the URN is valid and the UserSecretManager matches the expected type. - Remove the now unused `GLOBAL_INSTANCE` of the UnsafeInMemorySecretsManager. Testing - Existing `UnsafeInMemorySecretsManagerTest` captures most of the functional changes. - Added `UserSecretReferenceUrnHelperTest` to capture the utilities exposed. * Reuse shadowJar for spark client bundle jar maven publish (apache#1857) * fix spark client * fix test failure and address feedback * fix error * update regression test * update classifier name * address comment * add change * update doc * update build and readme * add back jr * udpate dependency * add change * update * update tests * remove merge service file * update readme * update readme * fix(ci): Remove dummy "build" job from Gradle CI (apache#1911) Since apache#1897, the jobs in gradle.yaml changed and the "build" job was split into many smaller jobs. But since it was a required job, it couldn't be removed immediately. * main: Update Quarkus Platform and Group to v3.23.3 (apache#1797) * main: Update Quarkus Platform and Group to v3.23.3 * Adopt polaris-admin test invocation --------- Co-authored-by: Robert Stupp <[email protected]> * Feature: Rollback compaction on conflict (apache#1285) Intention is make the catalog smarter, to revert the compaction commits in case of crunch to let the writers who are actually adding or removing the data to the table succeed. In a sense treating compaction as always a lower priority process. Presently the rest catalog client creates the snapshot and asks the Rest Server to apply the snapshot and gives this in a combination of requirement and update. Polaris could apply some basic inference and generate some updates to metadata given a property is enabled at a table level, by saying that It will revert back the commit which was created by compaction and let the write succeed. I had this PR in OSS, which was essentially doing this at the client end, but we think its best if we do this as server end. to support more such clients. How to use this Enable a catalog level configuration : polaris.config.rollback.compaction.on-conflicts.enabled when this is enabled polaris will apply the intelligence of rollbacking those REPLACE ops snapshot which have the property of polaris.internal.rollback.compaction.on-conflict in their snapshot summary to resolve conflicts at the server end ! a sample use case is there is a deployment of a Polaris where this config is enabled and there is auto compaction (maintenance job) which is updating the table state, it adds the snapshot summary that polaris.internal.rollback.compaction.on-conflict is true now when a backfill process running for 8 hours want to commit but can't because the compaction job committed before so in this case it will reach out to Polaris and Polaris will see if the snapshot of compation aka replace snapshot has this property if yes roll it back and let the writer succeed ! Devlist: https://lists.apache.org/thread/8k8t77dgk1vc124fnb61932bdp9kf1lc * NoSQL: nits * `AutoCloseable` for `PersistenceTestExtension` * checkstyle adoptions * fix: unify bootstrap credentials and standardize POLARIS setup (apache#1905) - unified formatting across docker, gradle - reverted secret to s3cr3t - updated docker-compose, README, conftest.py use POLARIS for consistency across docker, gradle and others. * Add doc for rollback config (apache#1919) * Revert "Reuse shadowJar for spark client bundle jar maven publish (apache#1857)" (apache#1921) …857)" This reverts commit 1f7f127. The shadowJar plugin actually stops publish the original jar, which is not what spark client intend to publish for the --package usage. Revert it for now, will follow up with a better way to reuse the shadow jar plugin, likely with a separate bundle project * fix(build): Gradle caching effectively not working (apache#1922) Using a `custom()` spotless formatter check effectively disables caching, see `com.diffplug.gradle.spotless.FormatExtension#custom(java.lang.String, com.diffplug.spotless.FormatterFunc)` using `globalState`, which is a `NeverUpToDateBetweenRuns`. This change refactors this to be cachable. We also already have a errorprone rule, so we can get rid entirely of the spotless step. * Update spark client to use the shaded iceberg-core in iceberg-spark-runtime to avoid spark compatibilities issue (apache#1908) * add change * add comment * update change * add comment * add change * add tests * add comment * clean up style check * update build * Revert "Reuse shadowJar for spark client bundle jar maven publish (apache#1857)" This reverts commit 1f7f127. * Reuse shadowJar for spark client bundle jar maven publish (apache#1857) * fix spark client * fix test failure and address feedback * fix error * update regression test * update classifier name * address comment * add change * update doc * update build and readme * add back jr * udpate dependency * add change * update * update tests * remove merge service file * update readme * update readme * update checkstyl * rebase with main * Revert "Reuse shadowJar for spark client bundle jar maven publish (apache#1857)" This reverts commit 40f4d36. * update checkstyle * revert change * address comments * trigger tests * Last merged commit 93938fd --------- Co-authored-by: Honah (Jonas) J. <[email protected]> Co-authored-by: Eric Maynard <[email protected]> Co-authored-by: Prashant Singh <[email protected]> Co-authored-by: Yufei Gu <[email protected]> Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: JB Onofré <[email protected]> Co-authored-by: Eric Maynard <[email protected]> Co-authored-by: Yun Zou <[email protected]> Co-authored-by: Pooja Nilangekar <[email protected]> Co-authored-by: Seungchul Lee <[email protected]>

github-project-automation bot added this to Basic Kanban Board Jun 12, 2025

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Jun 12, 2025

adutra commented Jun 12, 2025

View reviewed changes

quarkus/test-commons/build.gradle.kts Outdated

Copy link

Contributor Author

adutra Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkstyle depends on antlr4-runtime.

adutra mentioned this pull request Jun 12, 2025

Reuse shadowJar for spark client bundle jar maven publish #1857

Merged

feat(build): Add Checkstyle plugin and an IllegalImport rule

7f68ff2

adutra force-pushed the checkstyle-imports branch from 5e223b3 to 7f68ff2 Compare June 13, 2025 08:20

adutra marked this pull request as ready for review June 13, 2025 09:17

adutra requested review from HonahX, MonkeyCanCode, RussellSpitzer, ajantha-bhat, ashvina, collado-mike, dennishuo, dimas-b, ebyhr, eric-maynard, flyrain, gh-yzou, jackye1995, jbonofre, pingtimeout, singhpk234, snazy, takidau and vvcephei as code owners June 13, 2025 09:17

snazy reviewed Jun 13, 2025

View reviewed changes

review

52ffa16

dimas-b reviewed Jun 13, 2025

View reviewed changes

use regexp

79d22a7

dimas-b approved these changes Jun 13, 2025

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jun 13, 2025

gh-yzou reviewed Jun 13, 2025

View reviewed changes

gh-yzou approved these changes Jun 13, 2025

View reviewed changes

adutra merged commit f38ac8a into apache:main Jun 16, 2025
9 of 20 checks passed

adutra deleted the checkstyle-imports branch June 16, 2025 08:51

github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jun 16, 2025

flyrain pushed a commit that referenced this pull request Jun 18, 2025

feat(build): Add Checkstyle plugin and an IllegalImport rule (#1880)

5bcfea6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(build): Add Checkstyle plugin and an IllegalImport rule #1880

feat(build): Add Checkstyle plugin and an IllegalImport rule #1880

Uh oh!

adutra commented Jun 12, 2025 •

edited

Loading

Uh oh!

adutra Jun 12, 2025

Uh oh!

snazy Jun 13, 2025

Uh oh!

snazy Jun 13, 2025

Uh oh!

dimas-b Jun 13, 2025 •

edited

Loading

Uh oh!

dimas-b Jun 13, 2025

Uh oh!

snazy commented Jun 13, 2025

Uh oh!

adutra commented Jun 13, 2025

Uh oh!

gh-yzou Jun 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(build): Add Checkstyle plugin and an IllegalImport rule #1880

feat(build): Add Checkstyle plugin and an IllegalImport rule #1880

Uh oh!

Conversation

adutra commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adutra Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

snazy Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

snazy Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

dimas-b Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dimas-b Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

snazy commented Jun 13, 2025

Uh oh!

adutra commented Jun 13, 2025

Uh oh!

gh-yzou Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adutra commented Jun 12, 2025 •

edited

Loading

dimas-b Jun 13, 2025 •

edited

Loading