Revert "Reuse shadowJar for spark client bundle jar maven publish (#1… #1921
+12
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ache#1857)" This reverts commit 1f7f127.
flyrain
approved these changes
Jun 21, 2025
Contributor
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
+1 on reverting it. We will need to revert it in 1.0 branch as well.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
Author
|
@flyrain yes, once i got those the two PRs handled, i can take care of them together for 1.0 |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
flyrain
pushed a commit
that referenced
this pull request
Jun 23, 2025
)" (#1921) …857)" This reverts commit 1f7f127. The shadowJar plugin actually stops publish the original jar, which is not what spark client intend to publish for the --package usage. Revert it for now, will follow up with a better way to reuse the shadow jar plugin, likely with a separate bundle project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…857)"
This reverts commit 1f7f127.
The shadowJar plugin actually stops publish the original jar, which is not what spark client intend to publish for the --package usage.
Revert it for now, will follow up with a better way to reuse the shadow jar plugin, likely with a separate bundle project