Improve the parsing and validation of UserSecretReferenceUrns #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poojanilangekar
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
ajantha-bhat,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
Contributor
Author
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReference.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReferenceUrnHelper.java
Outdated
Show resolved
Hide resolved
poojanilangekar
commented
Jun 11, 2025
Contributor
Author
poojanilangekar
left a comment
poojanilangekar
left a comment
There was a problem hiding this comment.
Hey Eric, thanks for taking time to review the PR. I have implemented some of the changes you suggested and wanted to get some more clarity on the rest.
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReference.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReferenceUrnHelper.java
Outdated
Show resolved
Hide resolved
eric-maynard
approved these changes
Jun 13, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
auto-merge was automatically disabled
June 18, 2025 19:54
Head branch was pushed to by a user without write access
poojanilangekar
force-pushed
the
urn-regex
branch
from
50469f9 to
3ad02bb
Compare
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses all the TODOs found the org.polaris.core.secrets package.
Main changes:
String.split().GLOBAL_INSTANCEof the UnsafeInMemorySecretsManager.Testing
UnsafeInMemorySecretsManagerTestcaptures most of the functional changes.UserSecretReferenceUrnHelperTestto capture the utilities exposed.