fix(autofill): use static queries to read values used in ngOnInit #15515

pkozlowski-opensource · 2019-03-18T10:52:35Z

No description provided.

See scripts/ivy/README.md for instructions.

This makes the unit tests runnable on the ivy-2019 branch by making the following changes: * Use the unminified umd bundles. The minified bundles fail due to some yet indeterminate bug. * Update the install script to be platform independent (formerly only worked on macOS) * Skip the tree tests. Something about the tree tests crashes the test runner.

This is necessary to run `bazel` on Angular's CI

This should fix the tests for AriaDescriber, AutofillMonitor, Portal, BottomSheet, Autocomplete, and Drawer.

…uery (#15267)

Reworks a test that depends on static queries and fails under Ivy.

* Fixes one unit test that was depending on static queries. * Fixes the remaining 16 failures that were due to some code that was commented out while waiting for a task which was resolved.

This makes the test pass in ivy (as well as ViewEngine) since attribute bindings are set during creating mode in ivy.

This makes a test pass both with ivy and ViewEngine

…inserting (#15359) * fix(virtual-scroll): move views that are already attached instead of inserting * fix: add more static queries for cdk virtual scroll * refactor(button): use [attr.disabled] host binding in MatButton With ivy, MatAnchor will inherit the host bindings of MatButton. The `[disabled]` binding would then be an error since HTMLAnchorElement does not have a `disabled` property. To work around this, we can simply use the `disabled` attribute instead, which will always be reflected back into the property when it exists. Also add a missing `fixture.detectChanges()` to a test.

Fixes the chip list tests that are failing under Ivy due to a known breaking change.

7 tests are impacted

…] (#15456)

In Ivy inheriting `host` bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the `click` listener on the buttons will be invoked twice with Ivy. These changes rework the buttons so that they work both with Ivy and ViewEngine.

…tor (#15468) Due to changes in Angular it's not logical to change style values directly within a constructor. This should be done instead within the ngOnInit lifecycle hook. This patch changes this behavior for the `ToolTip` component.

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.

src/material-examples/text-field-autofill-monitor/text-field-autofill-monitor-example.ts

kara

LGTM

crisbeto

LGTM

ngbot · 2019-03-18T21:15:09Z

I see that you just added the pr: merge ready label, but the following checks are still failing:
     status "ci/circleci: api_golden_checks" is failing
     status "ci/circleci: bazel_build_test" is failing
     status "ci/circleci: build_release_packages" is failing
     status "ci/circleci: e2e_tests" is failing
     status "ci/circleci: lint" is failing
     status "ci/circleci: prerender_build" is failing
     status "ci/circleci: tests_browserstack" is failing
     status "ci/circleci: tests_local_browsers" is failing
     status "ci/circleci: tests_saucelabs" is failing
     missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

jelbourn · 2019-03-21T20:25:46Z

@pkozlowski-opensource I think this needs to be rebased

pkozlowski-opensource · 2019-03-22T09:41:49Z

@jelbourn opened a new PR: #15574

angular-automatic-lock-bot · 2019-09-10T16:01:53Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alxhub and others added 30 commits January 10, 2019 11:56

build: activate experimental Angular Ivy build of the demo app

9ff4d2d

See scripts/ivy/README.md for instructions.

fix: disable animation temporarily for ivy

3be11af

material demo app is running

678244b

chore(ivy): use yarn bazel consistently in install script (#14834)

fa7b7f3

chore(ivy): add @bazel/bazel to devDependencies (#14835)

a3b27cc

This is necessary to run `bazel` on Angular's CI

chore(ivy): filter unit tests based on a blacklist (#14846)

e721385

test: report karma results as json (#14860)

e60bbd2

chore: skip CI for ivy-2019 branch (#14868)

5c86cc4

build: do run "build_release_packages" job in ivy-2019 branch (#14871)

41f0185

chore: update yarn lock

5be6a20

chore: add script to generate ivy test blacklist (#14877)

031b06f

chore(ivy): re-enable tree tests

614d827

chore: update zonejs to 0.8.29

ebff165

chore: add node shebang to ivy/fix-tsconfig.js script

f4219b5

chore: make scripts/ivy/fix-tsconfigs.js executable

e55e8e9

chore: simplify ivy/install-angular.sh

fa37a80

chore(ivy): rename "blacklist" to "blocklist"

348b3ef

chore(ivy): avoid global error issues with karma-jasmine

fca1c02

chore: disable tests that are failing *only* on angular CI

0cee02b

chore(ivy): add static flag to tab-related static queries (#15238)

dc7467e

chore(ivy): add static flag to dialog-related static queries (#15239)

c502f78

chore(ivy): add static flag to more queries (#15252)

7ee4193

This should fix the tests for AriaDescriber, AutofillMonitor, Portal, BottomSheet, Autocomplete, and Drawer.

chore(ivy): add static flag to tree-related static queries (#15255)

f22561b

chore(ivy): add static flag to table-related static queries (#15257)

576abc5

chore(ivy): fix static query stragglers that were not marked static q…

ea7b7f2

…uery (#15267)

test(menu): refactor test that depends on static queries (#15289)

4d38453

Reworks a test that depends on static queries and fails under Ivy.

test(sidenav): fix sidenav failures under Ivy (#15300)

fcc0448

* Fixes one unit test that was depending on static queries. * Fixes the remaining 16 failures that were due to some code that was commented out while waiting for a task which was resolved.

test(grid-list): make error expectation less brittle (#15303)

f388871

This makes the test pass in ivy (as well as ViewEngine) since attribute bindings are set during creating mode in ivy.

test(slide-toggle): adding missing detectChanges() and tick() (#15309)

669d586

This makes a test pass both with ivy and ViewEngine

kara and others added 13 commits March 1, 2019 10:58

fix: restore virtualForOf properties (#15358)

ddc81f1

test(table): remove unnecessary test (#15391)

ab8a338

fix: move detectChanges call in tree spec to include trackBy (#15414)

171f128

test(chip-list): rework tests to work under Ivy (#15427)

e766a4f

Fixes the chip list tests that are failing under Ivy due to a known breaking change.

test(table): update static query test (#15450)

641e676

7 tests are impacted

fix(table): use default change detection strategy on table [from #15440…

a3f4f43

…] (#15456)

test(input): make the type validation test to pass in Ivy (#15461)

04b029c

refactor(datepicker): adapt custom header demo for Ivy (#15459)

a09ca7c

refactor(focus-monitor): adapt demo examples for Ivy (#15476)

e082c25

fix(stepper): content not being rendered out initially with ivy (#15486)

81d9995

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.

pkozlowski-opensource requested a review from jelbourn as a code owner March 18, 2019 10:52

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 18, 2019

kara suggested changes Mar 18, 2019

View reviewed changes

src/material-examples/text-field-autofill-monitor/text-field-autofill-monitor-example.ts Outdated Show resolved Hide resolved

fix(autofill): use static queries to read values used in ngOnInit

2363897

kara approved these changes Mar 18, 2019

View reviewed changes

crisbeto approved these changes Mar 18, 2019

View reviewed changes

crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 18, 2019

crisbeto added the P2 The issue is important to a large percentage of users, with a workaround label Mar 18, 2019

kara force-pushed the ivy-2019 branch from 2e18640 to 44f185b Compare March 20, 2019 04:12

pkozlowski-opensource closed this Mar 22, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(autofill): use static queries to read values used in ngOnInit #15515

fix(autofill): use static queries to read values used in ngOnInit #15515

Uh oh!

pkozlowski-opensource commented Mar 18, 2019

Uh oh!

Uh oh!

kara left a comment

Uh oh!

crisbeto left a comment

Uh oh!

ngbot bot commented Mar 18, 2019

Uh oh!

jelbourn commented Mar 21, 2019

Uh oh!

pkozlowski-opensource commented Mar 22, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

fix(autofill): use static queries to read values used in ngOnInit #15515

fix(autofill): use static queries to read values used in ngOnInit #15515

Uh oh!

Conversation

pkozlowski-opensource commented Mar 18, 2019

Uh oh!

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

crisbeto left a comment

Choose a reason for hiding this comment

Uh oh!

ngbot bot commented Mar 18, 2019

Uh oh!

jelbourn commented Mar 21, 2019

Uh oh!

pkozlowski-opensource commented Mar 22, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants