Skip to content

Conversation

@marclaval
Copy link
Contributor

Same as #15458 for the ivy-2019 branch

@marclaval marclaval requested a review from mmalerba as a code owner March 13, 2019 15:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@marclaval marclaval force-pushed the fixDatePickerDemoIvy2019 branch from eb21a1a to 8639517 Compare March 13, 2019 15:52
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2019
@ngbot
Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: bazel_build_test" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@marclaval marclaval force-pushed the fixDatePickerDemoIvy2019 branch from 8639517 to 69a81b5 Compare March 14, 2019 09:06
@marclaval marclaval requested a review from jelbourn as a code owner March 14, 2019 09:06
@marclaval
Copy link
Contributor Author

I've updated the example, PTAL

@mmalerba mmalerba merged commit a09ca7c into angular:ivy-2019 Mar 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants