chore(ivy): make unit tests runnable #14832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the unit tests runnable on the ivy-2019 branch by making the following changes: * Use the unminified umd bundles. The minified bundles fail due to some yet indeterminate bug. * Update the install script to be platform independent (formerly only worked on macOS) * Skip the tree tests. Something about the tree tests crashes the test runner.
googlebot
added
the
cla: yes
andrewseguin
added
pr: lgtm
action: merge
kara
pushed a commit
that referenced
this pull request
Mar 20, 2019
This makes the unit tests runnable on the ivy-2019 branch by making the following changes: * Use the unminified umd bundles. The minified bundles fail due to some yet indeterminate bug. * Update the install script to be platform independent (formerly only worked on macOS) * Skip the tree tests. Something about the tree tests crashes the test runner.
JoostK
pushed a commit
to JoostK/components
that referenced
this pull request
May 7, 2019
This makes the unit tests runnable on the ivy-2019 branch by making the following changes: * Use the unminified umd bundles. The minified bundles fail due to some yet indeterminate bug. * Update the install script to be platform independent (formerly only worked on macOS) * Skip the tree tests. Something about the tree tests crashes the test runner.
JoostK
pushed a commit
to JoostK/components
that referenced
this pull request
Jul 9, 2019
This makes the unit tests runnable on the ivy-2019 branch by making the following changes: * Use the unminified umd bundles. The minified bundles fail due to some yet indeterminate bug. * Update the install script to be platform independent (formerly only worked on macOS) * Skip the tree tests. Something about the tree tests crashes the test runner.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the unit tests runnable on the ivy-2019 branch by making the
following changes:
yet indeterminate bug.
worked on macOS)
runner.