feat: ✨ adds support for campaign classic #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging -> Main : EdgeIdentity Release 1.1.0
Staging -> Main Release EdgeIdentity 1.1.0
Update Sample App
Release Optimize Extension
…st (#202) (#203) * clean up core extension * fix review comments * add a new API: clearUpdatedConfiguration * update public docs * update android native implementation * add android:exported attribute to core extension's manifest file as it's required by Android 12 * Merge branch 'staging' into core (#201) # Conflicts: # apps/AEPSampleApp/ios/Podfile.lock * update core version
dsoffiantini
requested review from
PravinPK,
cacheung,
sbenedicadb,
spoorthipujariadobe,
swarna04 and
yangyansong-adbe
dsoffiantini
force-pushed
the
campaign-classic
branch
from
2e710a4 to
894b906
Compare
cacheung
reviewed
Sep 30, 2022
cacheung
reviewed
Sep 30, 2022
Contributor
cacheung
left a comment
cacheung
left a comment
There was a problem hiding this comment.
Have you run Sample App on iOS and Android? I encounter errors when running them. Can you check?
And let merge the PR to Staging first, not into main.
...oid/src/main/java/com/adobe/marketing/mobile/reactnative/optimize/RCTAEPCampaignClassic.java
Outdated
Show resolved
Hide resolved
dsoffiantini
force-pushed
the
campaign-classic
branch
2 times, most recently
from
e8e7fe2 to
2722005
Compare
dsoffiantini
force-pushed
the
campaign-classic
branch
7 times, most recently
from
66490e8 to
c3587b2
Compare
...oid/src/main/java/com/adobe/marketing/mobile/reactnative/optimize/RCTAEPCampaignClassic.java
Outdated
Show resolved
Hide resolved
dsoffiantini
force-pushed
the
campaign-classic
branch
5 times, most recently
from
ed39552 to
48e67b1
Compare
|
Looks like there are still some test failures on CI/CD. Is that expected? |
dsoffiantini
force-pushed
the
campaign-classic
branch
7 times, most recently
from
18cd226 to
7b91ae0
Compare
spoorthipujariadobe
approved these changes
Oct 25, 2022
dsoffiantini
force-pushed
the
campaign-classic
branch
from
7b91ae0 to
5d48c5c
Compare
cacheung
reviewed
Oct 25, 2022
Contributor
cacheung
left a comment
cacheung
left a comment
There was a problem hiding this comment.
Can we remove the .DS_Store file?
packages/campaignclassic/android/src/main/java/com/.DS_Store
packages/campaignclassic/android/src/main/java/com/adobe/.DS_Store
| { | ||
| "name": "@adobe/react-native-aepcampaignclassic", | ||
| "version": "1.0.0-beta.1", | ||
| "description": "Adobe Experience Platform support for React Native apps.", |
Contributor
There was a problem hiding this comment.
Experience Platform Campaign Classic extension for Adobe Experience Platform Mobile SDK. Written and Supported by Adobe.
cacheung
approved these changes
Oct 26, 2022
Contributor
cacheung
left a comment
cacheung
left a comment
There was a problem hiding this comment.
Looks good, just few comments.
Let fix the build before merge.
dsoffiantini
force-pushed
the
campaign-classic
branch
from
5d48c5c to
eeb5d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds wrapper code for Campaign Classic, sample app, documentation
How Has This Been Tested?
New unit tests have been added to cover new features
Types of changes
Checklist: