-
Notifications
You must be signed in to change notification settings - Fork 38
Staging -> Main : EdgeIdentity Release 1.1.0 #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getExperienceCloudId API
Update Readme
Some more Readme fix
Sync with Staging branch
Update links in Readme
update peer dependency edgeidentity version in messaging wrapper
update peerDependencies version
revert Messaging package.json, will update together with other wrappers in another PR
Update with review comments
* quick fix for peerDependecies issue * update sample app dependencies to latest versions
Update Edge Wrapper Readme
update readme
Update Edge Wrapper Readme
Update Readme and revert code
update package json for sample app
Add getExperienceCloudId() to EdgeIdentity
Fix a typo in sample app
Fix a typo in sample app
Add promise checking for error case
Remove the unused import statements
fix a typo in readme
* commit 'b58470acfaf35b5dc6abdabc413233d609de9a51': EdgeIdentity (1.0.0-alpha.2) -> main (#62) # Conflicts: # apps/AEPSampleApp/ios/Podfile.lock
add promise reject with error
Update Identity doc and fix
* commit 'a7d0febed8bcb7c58025bff4daa6a974953f3de4': Staging -> Main (typescript change) (#164) # Conflicts: # README.md # apps/AEPSampleApp/extensions/CoreView.tsx # apps/AEPSampleApp/ios/Podfile.lock # apps/AEPSampleApp/package.json # packages/assurance/package.json # packages/core/README.md # packages/core/package.json # packages/core/ts/MobileCore.ts # packages/edge/package.json # packages/edgeconsent/package.json # packages/edgeidentity/package.json # packages/userprofile/package.json
Update doc link for messaging in the readme
-a couple small updates from the pr review
add some of the extensions back into android sample app
Support for IAM in RN Messaging package
Add getUrlVariables API
Include lock files
remove AEPMobileOptimize
update edgeIdentity version number for Sample App in package.json
Update with review comments
Add rejected logic in getUrlVariable ts
Update package-lock and yarn.lock files
Update lock files
revert a text format
Add getUrlVariables API to EdgeIdentity package
Edge Identity 1.1.0 release
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this file? It's the configuration file for VSCode, it shouldn't be checked in.
yangyansong-adbe
approved these changes
Jun 28, 2022
Contributor
yangyansong-adbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one small comment.
remote extra file
remove extra file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EdgeIdentity Release 1.1.0
Add getUrlVariables API.
Also include partial messaging update.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: