Add getUrlVariables API to EdgeIdentity package #182
Conversation
Add getUrlVariables API
cacheung
changed the title
Include lock files
remove AEPMobileOptimize
update edgeIdentity version number for Sample App in package.json
cacheung
requested review from
addb,
dsoffiantini,
emdobrin and
yangyansong-adbe
.../main/java/com/adobe/marketing/mobile/reactnative/edgeidentity/RCTAEPEdgeIdentityModule.java
Outdated
Show resolved
Hide resolved
| [AEPMobileCore registerExtensions: @[AEPMobileEdgeIdentity.class, | ||
| AEPMobileEdge.class, | ||
| AEPMobileMessaging.class, | ||
| AEPMobileOptimize.class] completion:^{ |
There was a problem hiding this comment.
Should AEPMobileOptimize be removed here?
There was a problem hiding this comment.
The ci fails when I remove this, it is based in staging branch. I have to leave the AEPMobileOptimize here. Planning to merge this PR after Optimize PR, so should not be a problem.
There was a problem hiding this comment.
Just to confirm we are removing Optimize here and it will be added back with the Optimize PR?
There was a problem hiding this comment.
I was able to remove the Optimize extension without CI failure. Will keep it this way for edgeIdentity branch. It will be added back once merge to staging with AJO extension PR changes.
Update with review comments
Add rejected logic in getUrlVariable ts
Update package-lock and yarn.lock files
Update lock files
emdobrin
left a comment
emdobrin
left a comment
There was a problem hiding this comment.
Left a small question about the sample app dependencies, other than that looks good!
revert a text format
3 participants
Add getUrlVariables API
Description
Add getUrlVariables API, update sample app, update doc.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: