Skip to content

Add getExperienceCloudId() to EdgeIdentity #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 22, 2021
Merged

Add getExperienceCloudId() to EdgeIdentity #49

merged 16 commits into from
Sep 22, 2021

Conversation

@cacheung
Copy link
Contributor

@cacheung cacheung commented Sep 21, 2021

Add getExperienceCloudId() to EdgeIdentity
And update Readme

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cacheung
Add getExperienceCloudId API
9e36891 
Add getExperienceCloudId API
@cacheung
Update Readme
bdaa54e 
Update Readme
@cacheung
Some more Readme fix
f019b4d 
Some more Readme fix
@cacheung
Update links in Readme
85e6ce6 
Update links in Readme
@cacheung
update peer dependency edgeidentity version in messaging wrapper
55bb9c5 
update peer dependency edgeidentity version in messaging wrapper
@cacheung
update peerDependencies version
d5d75ee 
update peerDependencies version
@cacheung
revert Messaging package.json
20b1fdf 
revert Messaging package.json, will update together with other wrappers in another PR
emdobrin
emdobrin reviewed Sep 21, 2021
View reviewed changes
emdobrin
emdobrin approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@emdobrin emdobrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cacheung changes look good and let's revisit the Promise reject case separately.

@cacheung
Update Readme and revert code
596d224 
Update Readme and revert code
yangyansong-adbe
yangyansong-adbe approved these changes Sep 22, 2021
View reviewed changes
@cacheung
update package json for sample app
0155864 
update package json for sample app
@cacheung cacheung merged commit 37e8165 into adobe:edgeIdentity Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emdobrin emdobrin emdobrin approved these changes

@yangyansong-adbe yangyansong-adbe yangyansong-adbe approved these changes

@kevinlind kevinlind Awaiting requested review from kevinlind

Assignees

No one assigned

Labels

edgeIdentity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cacheung @emdobrin @yangyansong-adbe