-
Notifications
You must be signed in to change notification settings - Fork 38
Staging #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Staging #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st (#202) * clean up core extension * fix review comments * add a new API: clearUpdatedConfiguration * update public docs * update android native implementation * add android:exported attribute to core extension's manifest file as it's required by Android 12 * Merge branch 'staging' into core (#201) # Conflicts: # apps/AEPSampleApp/ios/Podfile.lock * update core version
Circleci update xcode
…into add-score-to-offer
feat: includes meta information in offer
Adds Places Extension
feat: adds target rn wrapper
feat: adds score to offer class, better type defs
Bump optimize version with new info
cacheung
reviewed
Aug 26, 2022
| { | ||
| "name": "@adobe/react-native-aepcore", | ||
| "version": "1.0.0", | ||
| "version": "1.0.1", |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to release core?
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "version": "1.0.1", |
The main branch shows 1.0.1 for core, I think it should be good to merge the PR.
Btw, I released the core 1.0.1 about a month ago : https://www.npmjs.com/package/@adobe/react-native-aepcore/v/1.0.1
cacheung
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds places extension, updates for core, updates for circleci
Motivation and Context
Allows users to use AEP Places functionality in their RN App
How Has This Been Tested?
New unit tests have been added to support the new package
Types of changes
Checklist: