Skip to content

Conversation

@dsoffiantini
Copy link
Contributor

@dsoffiantini dsoffiantini commented Aug 25, 2022

Description

Adds places extension, updates for core, updates for circleci

Motivation and Context

Allows users to use AEP Places functionality in their RN App

How Has This Been Tested?

New unit tests have been added to support the new package

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dsoffiantini and others added 13 commits June 9, 2022 10:59
…st (#202)

* clean up core extension

* fix review comments

* add a new API: clearUpdatedConfiguration

* update public docs

* update android native implementation

* add android:exported attribute to core extension's manifest file as it's required by Android 12

* Merge branch 'staging' into core (#201)

# Conflicts:
#	apps/AEPSampleApp/ios/Podfile.lock

* update core version
feat: includes meta information in offer
@dsoffiantini dsoffiantini marked this pull request as ready for review August 25, 2022 21:50
{
"name": "@adobe/react-native-aepcore",
"version": "1.0.0",
"version": "1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to release core?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


The main branch shows 1.0.1 for core, I think it should be good to merge the PR.

Btw, I released the core 1.0.1 about a month ago : https://www.npmjs.com/package/@adobe/react-native-aepcore/v/1.0.1

@dsoffiantini dsoffiantini merged commit daa1896 into main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants