Skip to content

Conversation

@dsoffiantini
Copy link
Contributor

Description

Adds wrapper for AEPTarget in React Native SDK

How Has This Been Tested?

Unit tests have been added and all existing tests pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dsoffiantini dsoffiantini requested a review from cacheung August 25, 2022 17:17
@dsoffiantini dsoffiantini force-pushed the target branch 6 times, most recently from 10f4fbc to b39c8e6 Compare August 25, 2022 21:39
Copy link
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add Target package to the main page - https://github.com/adobe/aepsdk-react-native/tree/target

Copy link
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsoffiantini dsoffiantini requested a review from cacheung August 26, 2022 16:15
Copy link
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants