-
Notifications
You must be signed in to change notification settings - Fork 38
feat: adds target rn wrapper #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
10f4fbc to
b39c8e6
Compare
cacheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add Target package to the main page - https://github.com/adobe/aepsdk-react-native/tree/target
cacheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Sample App iOS or Android, in the registration code, I don't see Target.
Android example - https://github.com/adobe/aepsdk-react-native/blob/target/apps/AEPSampleApp/android/app/src/main/java/com/aepsampleapp/MainApplication.java#L121
cacheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Adds wrapper for AEPTarget in React Native SDK
How Has This Been Tested?
Unit tests have been added and all existing tests pass
Types of changes
Checklist: